CHANGE LOG FOR UNIFIED 3DVAR CODE
-------------------------------------------
Author(s)  :  John Derber, Russ Treadon
Reviewer(s):  Ricardo Todling, Russ Treadon
Date       :  3/30/04                 

CVS version/tag:   ncep-gsi-1_1


REASON FOR CHANGES
------------------
   - Speed up and use less memory in polar patch and recursive filter 
      calculations
   - Fix bug in assignment of variance for ozone background error
   - Add code to turn off moisture constraint when no obs present
   - Correct bugs in stvp2uv & SpcCoeff_Define
   - Remove unused variable, nhalo, in gridmod



EXPECTED DIFFERENCES
--------------------
   - round-off
   - minor differences to ozone field global analysis only
   - if no data present, limq is now turned off.  only affect q
   - bug in stvp2uv only affected results in the case of an odd 
        number of latitudes on the analysis grid



GLOBAL TEST RESULTS
-------------------
Test case:   /nfsuser/g01/wx20rt/global_gsi/cases/global/sigma/t62l28/2004032212
             /nfsuser/g01/wx20rt/global_gsi/cases/global/sigma/t254l64/2004021012
Old code :   /nfsuser/g01/wx20rt/global_gsi/sorc/gsi_cvs/ 
New code :   /nfsuser/g01/wx20rt/global_gsi/sorc/changes/20040323_dp_jd.change
Machine  :   IBM
Setup    :   12 mpi tasks, blocking=unlimited

Max memory (T254L64 memory in parentheses)
   old: 158640 Kbytes (682660 Kbytes)
   new: 158640 Kbytes (682328 Kbytes)

Wall clock (T254L64 wall clock time in parentheses)
   old: 429.912512 seconds (1447.636841 seconds)
   new: 420.505657 seconds (1388.737459 seconds)

Output from final iteration of minimization
T62L28 test
old:   0: penalty,grad ,a,b=   3   1 0.280491846344094025E+06 0.822264402116889396E+05 0.191058956171423510E-02 0.105338653541229688E+01
new:   0: penalty,grad ,a,b=   3   1 0.280504821856384631E+06 0.768915534342758910E+05 0.204209522648718216E-02 0.914272701473710980E+00

T254L64 test
old:   0: penalty,grad ,a,b=   3   1 0.284935569104891445E+06 0.330591230572759923E+04 0.280657171354482945E-02 0.233863063411119976E+01
new:   0: penalty,grad ,a,b=   3   1 0.284929676005536225E+06 0.354842776608131589E+04 0.244003689252982221E-02 0.259406240071013183E+01




REGIONAL TEST RESULTS
---------------------
Test case:   /nfsuser/g01/wx20rt/global_gsi/cases/regional/wrfnmm/east_nest/2004021718
Old code :   /nfsuser/g01/wx20rt/global_gsi/sorc/gsi_cvs/ 
New code :   /nfsuser/g01/wx20rt/global_gsi/sorc/changes/20040323_dp_jd.change
Machine  :   IBM
Setup    :   12 mpi tasks, blocking=unlimited

Max memory
   old: 486884 Kbytes
   new: 486448 Kbytes

Wall clock
   old: 1132.841401 seconds
   new: 1074.613403 seconds

Output from final iteration of minimization
old:   0: penalty,grad ,a,b=   3   1 0.173637932371515672E+05 0.557860940907702898E+05 0.956470667036052433E-03 0.172686821105438953E+00
new:   0: penalty,grad ,a,b=   3   1 0.173637931867630577E+05 0.557863669998816695E+05 0.956466438626496344E-03 0.172690608606853313E+00




FILES REMOVED
-------------
   None





FILES ADDED
-----------
   None





FILES MODIFIED
--------------
   SpcCoeff_Define.f90 - assign value to RCS_Id in routine Count_SpcCoeff_Sensors
   berror.f90      - fix bug in set_ozone_var
   bkerror.f90     - wgthor redefined as square of previous value (applied once
                     rather than twice
                   - loop over 3 length scales moved to smooth routines
   glbsoi.f90      - eliminate parameter in call to set_ozone_var
   gridmod.f90     - remove variable nhalo since it is not used
   obs_para.f90    - turn off limq (set factqmin=0.0) if no observations
   polcarf.f90     - loops redefined to allow 1-d arrays rather than 2-d
   smoothgrf.f90   - loop over length scales brought inside routine and applied
                     after interpolation to 3 grids.
                   - summing moved inside lower level routines
                   - code clean-up
   smoothxy_reg.f90- loop over length scales brought inside routine
                   - summing moved inside lower level routines
                   - code clean-up
   stvp2uv.f90     - fix bug in xmulbv (logical odd undefined)


MAKEFILE CHANGES
----------------
   None



SCRIPT CHANGES
--------------
   None



FIX FILE CHANGES
----------------
   None